Potential fix for code scanning alert no. 30: Multiplication result converted to larger type #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onverted to larger type Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/IntelLabs/HEC-openfhe-development-test/security/code-scanning/30
To fix the problem, force the multiplication to occur in the larger type (
size_t) rather thanuint32_t. This is done by casting at least one operand of the multiplication (alphaorpart) tosize_tbefore the arithmetic operation. Specifically, replacesizePartQl = sizeQl - alpha * part;withsizePartQl = sizeQl - static_cast<size_t>(alpha) * part;. This change ensures that the multiplication is done with 64-bit arithmetic, preventing overflow so long as the result fits insize_t, and matches the intention of the code. Only line 355 needs to change; no new imports/definitions are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.