keyswitch-hybrid: avoid integer overflow in multiplication #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this PR were automatically generated by the Permanence AI Coder and reviewed by @eelenberg and @jweese. The 32-bit values `alpha` and `part` are being multiplied, and their product could overflow 32 bits before the result is promoted to a `size_t` to compute `sizePartQl`. To avoid the potential overflow, both operands are cast to `size_t`. The use of `auto` for `sizePartQl` changes its type (from explicit `uint32_t` to deduced `size_t`), but this is safe since its lifetime ends at the end of the `if` block, and it is only used as the initial size of two vectors. on-behalf-of: @permanence-ai [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR were automatically generated by the Permanence AI Coder and reviewed by @eelenberg and @jweese. The 32-bit values
alphaandpartare being multiplied, and their product could overflow 32 bits before the result is promoted to asize_tto computesizePartQl. To avoid the potential overflow, both operands are cast tosize_t.The use of
autoforsizePartQlchanges its type (from explicituint32_tto deducedsize_t), but this is safe since its lifetime ends at the end of theifblock, and it is only used as the initial size of two vectors.on-behalf-of: @permanence-ai [email protected]