Database rework with JPA + Hibernate + Liquibase #4748
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvited cluster users
… Flyway migrations
…tabase setup code
…oving DBFunc methods
Collaborator
|
Given this produces a ~52M jar, this cannot be considered to be merged or reviewed. |
Member
Author
|
There are possiblties to reduce the jar size |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces the database layer with intentional breaking changes. The aim is to modernize the architecture in some places.
Issues get maybe be fixed
Fixes #3573
Fixes #3274
Fixes #3573
Fixes #4128
Fixes #4105
Fixes #4612
Fixes #2994
Fixes #4732
Fixes #2963
Fixes #4326
Fixes #3237
Fixes #3287
Fixes #4386
Fixes #2273
Description
This PR replaces the current database layer with a combination of JPA, Hibernate,
FlywayLiquiBase, and Hikaricp.The use of Flyway is intended to ensure that an update to PlotSquared v8 is possible without data loss.
The design pattern repository was used extensively to enable testability. Named queries were also used to maintain high maintainability. Staying on the topic of queries, we use HQL (Hibernate Query Language) to enable users to also use other database types that are not supplied by PlotSquared as standard, e.g., h2, Postgresql, MS SQL, Oracle.
Flyway serves as a tool for making database schema changes in the future, allowing us to enforce third normal form in an 8.1 version to further flatten data handling and prevent problems.Open to-dos:
- [ ] (Improve StorageSQL configuration with https://commons.apache.org/proper/commons-configuration/)Submitter Checklist
@since TODO.