-
Notifications
You must be signed in to change notification settings - Fork 171
Update .NET package dependencies to latest compatible versions and fix CI network tests #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: BenjaminMichaelis <[email protected]>
…k exceptions Co-authored-by: BenjaminMichaelis <[email protected]>
I've fixed the CI failures. The issue was that Chapter05 tests were trying to download files from google.com and intellitect.com, but the CI environment blocks DNS requests to external sites. The tests had exception handling for I've updated the exception handling in the affected test files to catch a broader range of network-related exceptions and properly mark those tests as inconclusive when network access is blocked. The tests now handle DNS blocking gracefully. Fixed in commit a987c6b. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR updates the NuGet package dependencies in the repository to their latest compatible versions to ensure the project benefits from the latest security fixes, bug fixes, and performance improvements. Additionally, fixes CI test failures caused by DNS blocking in the build environment.
Changes Made
Updated the following packages in
Directory.Packages.props:Fixed Chapter05 network-dependent tests to handle DNS blocking in CI environments by enhancing exception handling to catch a broader range of network-related exceptions (
SocketException,TaskCanceledException,NetworkInformationException) in addition to the originalHttpRequestException. Tests now properly mark as inconclusive when network access is blocked rather than failing.Compatibility Notes
Microsoft.NET.Test.Sdk was intentionally kept at version 17.13.0 instead of upgrading to the latest 17.14.1 because the newer version doesn't support .NET 6.0 and .NET 7.0 target frameworks. Since this repository maintains backward compatibility across multiple .NET versions (net6.0, net7.0, net8.0) for educational purposes, keeping the compatible version ensures all target frameworks continue to work properly.
Testing
dotnet list package --outdatedthat all feasible updates have been appliedThe repository uses centralized package management via
Directory.Packages.props, which ensures consistent package versions across all projects and makes dependency management clean and maintainable.This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.