Skip to content

Conversation

@fghalasz
Copy link
Member

No description provided.

@pamoroso
Copy link

pamoroso commented Nov 6, 2025

Is this the correct URL for running Insphex in commit 8d0b6e6? It leads to a default guest session without Insphex.

https://online.interlisp.org:8081/guest?start=https%3A%2F%2Fraw.githubusercontent.com%2FInterlisp%2Fonline%2Frefs%2Fheads%2Ffgh_museum-mode%2Ftest%2Fstart-scripts%2FSTART-INSPHEX

@fghalasz
Copy link
Member Author

fghalasz commented Nov 7, 2025

@pamoroso That WAS the correct URL. But the weekly update to Online Medley overwrote the development docker image as well as the production docker image of Online Medley. I will fix this. The correct museum mode" Medley image is now up and running on online.interlisp.org:8081.

I moved the start scripts from online/test/start-scripts to online/start-scripts. I also added to the start scripts directory files called START-XXX.URL that contain the full encoded URL to utilize that start-script.

I had a lot of trouble getting the START-INSPHEX script to work - mostly due to issues with packages. I ended up with the weird ADD.PROCESS construction at the end of the START-INSPHEX function.

Also in START-INSPHEX function I ended up advising INSPHEX::CREATE-HEX-WINDOW so that I could specify the window size and location in the call to INSPHEX:HEXDUMP. It just works better as a demo that way rather than asking the user to sweep out a window region first thing. It might be a good enhancement to change the second argument to HEXDUMP to be either a window or a non-NIL, non-window. If its a window then use it as the TEdit window and if its non-NIL, non-Window then create a window (or use the previous Window from TEdit).

@pamoroso
Copy link

pamoroso commented Nov 8, 2025

I agree. Having to advise TEdit to create a window of specified size and location is unnecessarily awkward and interferes with the user interface. In museum mode the menu of Insphex is detached from the main window:

insphex1

But the menu should actually be attached as in this screenshot without advice:

insphex2

I can change the second argument to HEXDUMP in a backward compatible way so that it can be a window to use as is, or another true value to let the user swipe out a window as the current behavior. Perhaps the second argument could also be just a region instead of a window. Which option is better?

Notice that all the text is underlined in the readonly TEdit window. This is unrelated to the museum mode code and is an effect of the latest rounds of TEdit changes. I'll figure this out.

@pamoroso
Copy link

pamoroso commented Nov 8, 2025

The /demo/login route leads me to a guest session and /demo/guest works as expected.

@fghalasz
Copy link
Member Author

fghalasz commented Nov 8, 2025

I would prefer to have just HEXDUMP accept a WINDOW rather than a REGION. Gives the caller more control over the properties of the window.

The demo/login route is not working as yet. Debugging now.

@pamoroso
Copy link

pamoroso commented Nov 9, 2025

Okay I'll change the function to accept a window.

@pamoroso
Copy link

pamoroso commented Nov 9, 2025

I changed Insphex so that INSPHEX:HEXDUMP accepts a window as the optional second argument, but be sure to set a title for the window otherwise the hex dump window won't have any.

Are you still working on the /demo/guest and /demo/login paths?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants