Fix cache sizing and cache block layout edge cases#4552
Open
grimoire wants to merge 4 commits intoInternLM:mainfrom
Open
Fix cache sizing and cache block layout edge cases#4552grimoire wants to merge 4 commits intoInternLM:mainfrom
grimoire wants to merge 4 commits intoInternLM:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes several cache sizing and cache block layout edge cases in the PyTorch engine, and improves readability around cache configuration/update logic.
Changes
ExecutorBase.update_configs()into smaller helper methods to make cache memory estimation easier to follow.num_gpu_blocks.cache_max_entry_countto pageable KV cache memory.target_cache_block_size + spec_cache_block_size;target_cache_block_size;num_gpu_blocksis the minimum capacity across ranks.block_sizeandkernel_block_size:block_size >= kernel_block_size;block_size % kernel_block_size == 0.block_size != kernel_block_sizefor PD migration, both in engine checker and migration runtime path.kernel_block_size;kernel_block_size.Tests