-
Notifications
You must be signed in to change notification settings - Fork 25
gRPC: Add decoded PlutusData and NativeScript in proto definition #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2a68c4a to
0da56f8
Compare
palas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is all accurate except for the bigint representation, which I am sure you already considered. But I commented on the bits that I found suspicious, even though I think they are all correct
Jimbo4350
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM however you should start implementing round trip tests for your Inject instances and consider having a separate type class for these transformations.
I'll approve once the round trip tests are added.
f857964 to
a345801
Compare
7a9b167 to
97c55d9
Compare
27dd02b to
810f789
Compare
ca99912 to
147cb62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
147cb62 to
a60f3b5
Compare
4caaa17 to
dcf43dd
Compare
768f771 to
ccacd4c
Compare
ab400b4 to
1c90b69
Compare
1c90b69 to
8be0f75
Compare
e1eae2b to
adcef0d
Compare
Changelog
Context
Previously,
NativeScriptandPlutusDatawere omitted in the ReadUtxos query feature:This PR adds decoding of those values to the protobuf type. Using protobuf-defined values instead of CBOR blobs is advantageous, as it lets UTxO RPC consumers work with a single data format.
A rountrip property test is included.
Checklist