Skip to content

Conversation

@Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Remove eon from `AnyVote`
  type:
  - breaking       
  - refactoring    
  projects:
  - cardano-api

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

ShelleyBasedEraAlonzo -> id
ShelleyBasedEraBabbage -> id
ShelleyBasedEraConway -> overwrite votingProcedures
ShelleyBasedEraDijkstra -> overwrite votingProcedures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we avoid matching on every era? This just adds a boilerplate to maintain. Why not

let era = either (const Nothing) pure $ sbeToEra sbe
maybe id (\era' -> obtainEraCommonConstraints era' $ overwrite votingProcedures) era

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants