Refactor Run modules to use modern record extensions#830
Closed
mwihoti wants to merge 10 commits into
Closed
Conversation
Contributor
Author
|
Hi @jorisdral , I just pushed an update for Run module with the new record language extensions, I'm moving next to Index |
jorisdral
requested changes
Mar 25, 2026
Collaborator
There was a problem hiding this comment.
Thank you very much for the contribution, I like the new field names for the Run and RunReader module 😄.
Two high-level comments:
- In modules where we refactor field names (
Run/RunReader), we should enableDuplicateRecordFields,NoFieldSelectors, andOverloadedRecordDot. In other modules where we only want to use the.fieldsyntax, it should be fine to only enableOverloadedRecordDot, so let's change that so that we only use the.fieldsyntax on values of typeRunandRunReader. That probably makes the diff of this PR also smaller - There are some residual parentheses here and there. In particular, we don't need parentheses around syntax like
value.field
Contributor
Author
|
Thanks, I will work on the changes |
mwihoti
force-pushed
the
feature/811-modern-record-extensions
branch
from
343017b to
5823d35
Compare
Contributor
Author
|
Hi @jorisdral I've updated changes based on the feedback |
Contributor
Author
|
Hello, @jorisdral I'would like to proceed next to index, could you check if what I've done aligns well |
jorisdral
approved these changes
Apr 15, 2026
Collaborator
There was a problem hiding this comment.
There are redundant parentheses around record-dot syntax in this module
extension scope
- Remove unnecessary parentheses around dot-access expressions (value.field)
- Only enable DuplicateRecordFields/NoFieldSelectors in Run and RunReader
where field names were actually refactored; other modules get
OverloadedRecordDot only
Snapshot.hs: use exported runFsPaths accessor instead of internal r.fsPaths
Unsafe.hs: restore parens around function applications
Config/Override.hs: fix corrupted override instance for MergeBatchSize
Benchmarks: update to dot syntax with renamed fields (bloomFilter, index,
kOpsFile) and add OverloadedRecordDot pragma to both benchmark files
mwihoti
force-pushed
the
feature/811-modern-record-extensions
branch
from
6568b11 to
04c4cec
Compare
Contributor
Author
|
Hi, @jorisdral I've solved based on comments. |
Collaborator
Contributor
Author
|
@jorisdral you are welcome, let me know if I can proceed on index |
Collaborator
Feel free to proceed whenever you want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the successful pilot with Internal.Arena, this PR refactors the Run module and several related components to use the modern record language extensions.
changes
cabal build lsm-tree:lib:core -- Builds successfully
cabal test lsm-tree-test --pattern "Run" -- 129/129 tests pass
cabal test all -- Verified for compilation and linking
link
to the issue.
Checklist