fix: fix debug options#5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a functional “debug mode” toggle so debug logs can be enabled/disabled based on config.yml across the supported platforms (Bukkit/Bungee/Velocity).
Changes:
- Add
setDebugEnabled(boolean)toItemShopLoggerand wire it up during plugin enable. - Gate
debug()output behind adebugEnabledflag in each platform logger implementation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
itemshopsys-velocity/src/dev/shiza/itemshopsys/velocity/ItemShopVelocityLogger.java |
Adds a debugEnabled flag and skips debug logging when disabled. |
itemshopsys-common/src/dev/shiza/itemshopsys/ItemShopPluginImpl.java |
Reads config.debug and applies it to the logger during onEnable(). |
itemshopsys-common/src/dev/shiza/itemshopsys/ItemShopLogger.java |
Adds a new default setDebugEnabled API. |
itemshopsys-bungee/src/dev/shiza/itemshopsys/bungee/ItemShopBungeeLogger.java |
Adds a debugEnabled flag and skips debug logging when disabled. |
itemshopsys-bukkit/src/dev/shiza/itemshopsys/bukkit/ItemShopBukkitLogger.java |
Adds a debugEnabled flag and skips debug logging when disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public final class ItemShopBukkitLogger implements ItemShopLogger { | ||
|
|
||
| private final Server server; | ||
| private boolean debugEnabled; |
| public final class ItemShopBungeeLogger implements ItemShopLogger { | ||
|
|
||
| private final ProxyServer server; | ||
| private boolean debugEnabled; |
| public class ItemShopVelocityLogger implements ItemShopLogger { | ||
|
|
||
| private final java.util.logging.Logger logger; | ||
| private boolean debugEnabled; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.