[release/2.1] Update netcdf-c from spack develop to fix missing plugins#58
Merged
climbfuji merged 16 commits intoMay 13, 2026
Conversation
Even though netcdf-c is only supposed to depend on curl when +dap, it doesn't correctly do this until 4.9.3 * ensure netcdf-c depends_on curl * Apply only when build_system=cmake
* Patch the networkdirect and msmpi package build systems to be compatible with being built and installed in stages and prefixes whose paths contain spaces * Add mpi to the Windows gitlab CI by enabling the +mpi variant of vtk and paraview * Add patch to fix netcdf-c build error on Windows (Paraview dependency) * Tweak seacas dependencies on Windows (vtk dependency) * Add external win-wdk entry to the GL CI packages.yaml that corresponds to the existing win-sdk version
…3.9.3 update (spack#1157) * netcdfc: ensure patchs are applied to only appropriate versions * NetcdfC: update and add patches * Update version boundaries on MPI CSD patch * Add include patch for 4.9.3 * netcdf: patch to utf-8 --------- Signed-off-by: John Parent <john.parent@kitware.com>
…spack#1712) Netcdf-c && Proj Fixes for CMake based Curl (fixes broken develop CI) Signed-off-by: John Parent <john.parent@kitware.com>
* do not use deprecated argument * conflict the removed jna feature * add new byterange requirement * use new option for blosc * use new option for zstd * handle bz2
* Logic to install plugins for cmake netcdf-c builds
…ind MPI functions when build system is cmake
…ith intel-oneapi-compilers+intel-oneapi-mpi and gcc+openmpi
Explicitly set CMAKE_INSTALL_RPATH_USE_LINK_PATH to TRUE
Otherwise CMake will choke on a Windows escape character if based in the C: drive Signed-off-by: John Parent <john.parent@kitware.com>
10 tasks
25 tasks
Collaborator
Author
|
@rickgrubin-noaa can you also review and approve this, please? |
rickgrubin-noaa
approved these changes
May 13, 2026
github-project-automation
Bot
moved this from In Progress
to Done
in spack-stack-2.1.x (2026 Q1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks a series of commits from spack
developto fix the issue with missing plugins reported in JCSDA/spack-stack#1997. This PR is forrelease/2.1.Because I cherry-picked the commits, other files are updated as well. I believe this is ok. I could go in and manually undo those changes in a single commit and then remove this commit when merging the changes down to develop. Thoughts?
Testing
See JCSDA/spack-stack#2010