Spackify JEDI components for NEPTUNE-JEDI#1887
Spackify JEDI components for NEPTUNE-JEDI#1887climbfuji wants to merge 45 commits intoJCSDA:developfrom
Conversation
.gitmodules and submodule pointer for spack for code review and testing
…g,gcc,oneapi}.yaml; remove outdated packages yaamls for aocc, apple-clang, intel classic
…eature/update_spack-stack-dev_from_develop
…/ubuntu-ci-x86_64-oneapi.cfg and .github/workflows/ubuntu-ci-x86_64-oneapi-ifx.cfg
…es.yaml to avoid duplicate packages
…o prevent build errors with gcc when generator=ninja
…hod to determine preferred compiler
…eview and testing
…eature/update_spack-stack-dev_from_develop
… for external openmpi
… spack-stack repo; add as variant to jedi-neptune-env and enable variant in neptune-dev environment template
…/github.com/climbfuji/spack-stack into feature/update_spack-stack-dev_from_develop
…eature/jedi_components
|
@climbfuji, thank you for carrying this through. The dates encapsulated in the package version numbers are perhaps a bit confusing. For example, ioda version |
Agreed, and still being worked on. I need those for now as these are the hashes that neptune-bundle points to as of 2026/01/20. Likely won't get merged as is. We also discussed yesterday at the spack-stack meeting the desire to point to official tags of JEDI whenever possible. If we can't do this right away with neptune-bundle, then maybe using the date that the commit was made is a better idea. |
…compiler requirements; set mkl variant for oops
…converters/package.py to install missing scripts
…eature/jedi_components
…eature/jedi_components
…eature/jedi_components
…-dev-llvm/spack.yaml configs/templates/unified-dev/spack.yaml, replace crtm@3.1.2 and crtm@v2.4.1-jedi.2 with crtm@3.1.3
….py (Intel ctests), repos/spack_stack/spack_repo/spack_stack/packages/ufo/package.py (no more crtm@2), repos/spack_stack/spack_repo/spack_stack/packages/jedi_neptune_env/package.py (ditto)
…eature/jedi_components
…eature/jedi_components
…ll enabled ctests pass with GCC and Intel oneAPI
| - +fftw | ||
| oops: | ||
| require: | ||
| - ~mkl No newline at end of file |
There was a problem hiding this comment.
| - ~mkl | |
| - ~mkl | |
| - | |
| #url = https://github.com/jcsda/spack-packages | ||
| #branch = spack-stack-dev | ||
| url = https://github.com/climbfuji/spack-packages | ||
| branch = feature/crtm_checks No newline at end of file |
There was a problem hiding this comment.
this will be reverted anyway
Summary
Much credit and thanks to @rhoneyager-tomorrow for the original PR to JCSDA/spack (now stale): JCSDA/spack#395.
This PR updates the JEDI packages from PR JCSDA/spack#395 that are relevant for NEPTUNE-JEDI (aka FALCON project) and adds them to our custom repo under
repos/spack_stack. Building these components in spack-stack and providing them as modules allows us to reduce the NEPTUNE-JEDI build to a small number of repositories that are controlled and developed by NRL only, and - very important - allows us to implement a pure CMake build at the top level (neptune-bundle/neptune-ecosystem) without having to deal withecbuild. A small change is made to thecrtmpackage (inrepos/builtin) to enable basic testing duringspack install.Notes/Limitations
gcc@13) and Intel oneAPI (testedoneapi@2025.3.0). I made sure that the tests that are disabled are not related to the Spack package, but to the code itself or other issues outside of the scope of this PR. To run these tests, usespack install --test=root ioda, for example.ropp-ufocode is coming from the NRL Enterprise GitHub because of the unresolved issue https://github.com/JCSDA-internal/ropp-ufo/issues/1.Testing
neptune-devtemplate usinggcc@13on @climbfuji's development system, and on DOD HPCMP Nautilus (gcc@13.3.1,intel-oneapi-compilers@2025.3.0).Applications affected
NEPTUNE-JEDI
Systems affected
None directly
Dependencies
Issue(s) addressed
This PR replaces a large part of JCSDA/spack#395.
Testing
Checklist
All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged