Skip to content

add prefixes at categories methods#19

Open
alphatroya wants to merge 1 commit into
JJSaccolo:masterfrom
alphatroya:feature/atr-deprecateRefactoring
Open

add prefixes at categories methods#19
alphatroya wants to merge 1 commit into
JJSaccolo:masterfrom
alphatroya:feature/atr-deprecateRefactoring

Conversation

@alphatroya
Copy link
Copy Markdown

Categories methods should have prefixes. SDWebImage authors make sd_ prefix at all their methods and I make this too. I mark old methods as deprecated.

@ricsantos
Copy link
Copy Markdown

This PR should be considered for merging as it improves consistency with SDWebImage. Perhaps don't worry about deprecating the methods though, just replace with the new sd prefixed methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants