-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Convert fixed-value ComboBoxes to SearchableComboBox (#14083) #14165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Convert fixed-value ComboBoxes to SearchableComboBox (#14083) #14165
Conversation
| <SearchableComboBox fx:id="pushToApplicationCombo" | ||
| prefWidth="200.0" GridPane.columnIndex="1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editable false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing that out. I have added editable="false" as suggested.
I will push the updated code shortly.
|
This covers also #14082 , an issue that was already assigned to @Memeel . So the other should be merged first and this one after, to have the commiter history show proper credit. @CodeRishiX please look out for issues already assigned next time. JabRef tries to be a OSS beginner friendly project where everybody following the rules gets a chance. |
|
Merge after #14189 |
Thanks for letting me know! I'll make sure to check issue assignments before working next time. |
|
@CodeRishiX The other PR was just merged for the entry types, can you please resolve the merge conflicts now?= |
Sure. |
Updated CHANGELOG to include changes regarding ComboBoxes.
Hi @Siedlerchr, after resolving the changelog conflict, I see that it's now failing on 2 Jabilib unit tests. Since these failures did not happen in my earlier commits and I haven't changed related code. |
|
if you click on the details of the failing test you see |

Closes #14083
Converted fixed-value ComboBoxes in the Preferences dialog & Web Search to SearchableComboBoxes for improved usability.
Updated sections include General, Web Search, Entry Types, and External Programs.
Steps to test
In Web Search, click the Service dropdown and use keyboard input to quickly jump to and cycle among matching services.
In Preferences → General, open the Language dropdown and filter languages by typing.
In Preferences → Entry Types, add or edit a field and observe that the Field selection dropdown now live-filters as you type.
In Preferences → External Programs → Push Applications → Application to push entries to, use the dropdown to confirm it filters results dynamically as you type.
Known Observations
While testing Preferences → General → Language, I noticed that the SearchableComboBox only matches exact text.
For example, searching for “espanol” does not bring up “Español,” and “filipino” does not match “Tagalog/Filipino.”
This affects certain languages (e.g., Español, Deutsch, Suomi, Nederlands, Tagalog/Filipino, Français) where accents or alternate spellings prevent matches.
In Preferences → AI → Chat model dropdown, users can type inside the field, but it does not filter or search the choices as expected. Instead, it allows input but does not match or autocomplete available models. This may cause confusion, as it appears to be editable but does not work as a searchable/filterable dropdown.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)