Skip to content

Replace urllib2 components in got3, pep8#129

Open
eilifm wants to merge 1 commit intoJefferson-Henrique:masterfrom
eilifm:urllib_p3_bug
Open

Replace urllib2 components in got3, pep8#129
eilifm wants to merge 1 commit intoJefferson-Henrique:masterfrom
eilifm:urllib_p3_bug

Conversation

@eilifm
Copy link

@eilifm eilifm commented Dec 1, 2017

Substative Changes:
Replace urllib2 components with equivalent urllib3 components.
For example:


        if proxy:
            opener = urllib.request.build_opener(urllib.request.ProxyHandler(
                {'http': proxy, 'https': proxy}), urllib.request.HTTPCookieProcessor(cookieJar))
        else:
            opener = urllib.request.build_opener(urllib.request.HTTPCookieProcessor(cookieJar))
        opener.addheaders = headers

Style Changes:
Ran PEP8 autostyle tool to convert tabs to spaces and other standard styling changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants