[JEWEL-553] Updating TabStrip style #3289
Open
+305
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
requested review from
daaria-s,
jakub-senohrabek,
nebojsa-vuksic and
rock3r
faogustavo
force-pushed
the
gv/JEWEL-553
branch
from
538536d to
06c8863
Compare
faogustavo
force-pushed
the
gv/JEWEL-553
branch
from
06c8863 to
679e72b
Compare
rock3r
suggested changes
Nov 7, 2025
| ScrollbarVisibility.WhenContainerHovered( | ||
| trackThickness = 5.dp, | ||
| trackThicknessExpanded = 5.dp, | ||
| trackPadding = PaddingValues(1.dp), |
Collaborator
Author
There was a problem hiding this comment.
Yes, the value used in swing is JBUI.insets(1) (which is all sides)
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ScrollableContainer.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ScrollableContainer.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ScrollableContainer.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ScrollableContainer.kt
Outdated
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/styling/ScrollbarStyling.kt
Outdated
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-553
branch
from
679e72b to
90f2733
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...ewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridgeScrollbar.kt
Show resolved
Hide resolved
faogustavo
force-pushed
the
gv/JEWEL-553
branch
from
90f2733 to
ebf8d5b
Compare
rock3r
reviewed
Nov 18, 2025
| public override val trackThicknessExpanded: Dp = trackThickness | ||
| public override val expandAnimationDuration: Duration = 0.milliseconds | ||
| public override val lingerDuration: Duration = 0.milliseconds | ||
| public constructor( |
Collaborator
There was a problem hiding this comment.
Shouldn't this this be deprecated/hidden?
Collaborator
Author
There was a problem hiding this comment.
I thought about it, but the usage with fewer parameters is still valid, so I wasn't sure. Let me check what happens if I hide this and add default arguments.
Collaborator
Author
There was a problem hiding this comment.
That's weird, setting this to hidden and adding the parameters with default values did not change the dump file 🤔
Collaborator
There was a problem hiding this comment.
I don't trust the IJP dump files much... That's why we have metalava lol
- Updated TabStrip to use ScrollableContainer - Updated ScrollableContainer to allow setting the position of scrollbar - Updated TabStrip scrollbar theme on LaF + Stand-alone - Updated TabStrip implementation to properly handle different style based on the hover state
faogustavo
force-pushed
the
gv/JEWEL-553
branch
from
ebf8d5b to
4151d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidences
Before & After
Stand-alone vs IDE
Normal scrollbars: Nothing changed
Release notes
New features
ScrollbarVisibility.WhenContainerHoveredVisibility typeVerticalScrollbarandHorizontalScrollbarcomposablesBug fixes
Note
Refactors TabStrip to use HorizontallyScrollableContainer with a start-positioned, hover-colored tab-strip scrollbar, and extends scrollbar API/styling (positions, expanded padding, tab-strip visibility).
HorizontallyScrollableContainer(replacing manual scroll + overlay), placing scrollbar atStart.rememberTabStripScrollbarStyle; removes explicitAnimatedVisibility.ScrollbarPositionand support to place scrollbars atStart/EndinScrollableContainerImpl.ScrollbarVisibility.trackPaddingExpandedand uses it when expanded; refines hover/drag visibility logic and animations.PaddingValues()) for Windows/Linux variants.ScrollbarVisibility.tabStrip(...)with 5.dp thickness and tuned animations; deprecatesAlwaysVisible.tabStrip(...)overload.readTabStripScrollbarStyle()and switches tab styles to use it.Written by Cursor Bugbot for commit 4151d75. This will update automatically on new commits. Configure here.