fix: timeout not respected because join() called before timeout check #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faanbaria
force-pushed
the
fatima/fix-executor-timeout
branch
from
8160efc to
b3dac7f
Compare
Faanbaria
changed the title
Faanbaria
force-pushed
the
fatima/fix-executor-timeout
branch
from
3cd4308 to
f8444c5
Compare
Faanbaria
force-pushed
the
fatima/fix-executor-timeout
branch
from
f8444c5 to
2f0a157
Compare
Removed duplicate sleep-only timeout tests. Added withTimeout to prevent tests from hanging if fix breaks. Tests now verify partial output capture.
Faanbaria
force-pushed
the
fatima/fix-executor-timeout
branch
from
75b3a20 to
cd0a2b3
Compare
destroying descendants is necessary
Faanbaria
force-pushed
the
fatima/fix-executor-timeout
branch
from
40ab6f1 to
3f4d0ef
Compare
Qodana for JVM1191 new problems were found
@@ Code coverage @@
+ 71% total lines covered
16418 lines analyzed, 11797 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
serge-p7v
pushed a commit
that referenced
this pull request
Dec 2, 2025
…#1005) The executor kept running past the timeout limit. This happened because join() was called on stream jobs before checking if timeout occurred. Now we check for timeout first, then call join(). Updated tests to verify timeouts work correctly. --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated --------- Co-authored-by: Bruno Lannoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executor kept running past the timeout limit. This happened because join() was called on stream jobs before checking if timeout occurred. Now we check for timeout first, then call join(). Updated tests to verify timeouts work correctly.
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature