test(server): wait for PTY readiness conditions - #334
Merged
Conversation
ThinkRail-Todo: 01a044f6-279b-75c3-a440-a55eb3615acc/t_453990950ca1
ThinkRail-Todo: 01a044f6-279b-75c3-a440-a55eb3615acc/t_3d9e112ad362
ThinkRail-Todo: 01a044f6-279b-75c3-a440-a55eb3615acc/t_7fce3d1f998e
ThinkRail-Todo: 01a044f6-279b-75c3-a440-a55eb3615acc/t_3d9e112ad362
danyaberezun
requested review from
Olga Lavrichenko (OLavrik),
Rustam Sadykov (SBOne-Kenobi) and
Rinat S (rsolmano)
as code owners
August 27, 2026 21:20
Rinat S (rsolmano)
enabled auto-merge (squash)
August 28, 2026 16:22
Rinat S (rsolmano)
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #290
Changes
terminal.databatches for the expected terminal id and wait for the matchingterminal.exitbefore reattach/persistence assertions.Testing
bun run check:deps— passed.bun run check:seams— passed.bun run lint— passed with six pre-existing unused-suppression warnings outside this diff.bun run typecheck— 11/11 tasks passed.bun run test— 11/11 tasks passed; server 846/846 tests passed.SHELL=/usr/bin/bash bun test packages/server/src/terminal/terminalManager.test.ts --rerun-each=3— 78/78 passed.SHELL=/usr/bin/zsh bun test packages/server/src/terminal/terminalManager.test.ts --rerun-each=5— 130/130 passed under concurrent verification load.--rerun-each=3— 12/12 passed.bun run e2e— 298/298 passed before the final timeout-only hardening commit; not rerun on the final head locally, with current-head coverage left to CI.