-
Notifications
You must be signed in to change notification settings - Fork 634
feature: Separate dialog history of each agent #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature: Separate dialog history of each agent #248
Conversation
|
I'm supportive of separating history by agent in a better way than provided today. But I'm not immediately a fan of the other changes. If you want to open an issue for removing default agent and forcing the user to always specify an agent, we could see what others in the community think and get some discussion. Probably should be separate PRs. |
b8558bc to
08d79dc
Compare
|
Thanks for the review :) |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
|
So I think the simplified change creates a few problems, particularly in the interaction with the streamlit app (maybe we need to add tests for those)
I guess we would ideally provide some tests for this functionality as well, since the tests are passing even though the user interaction behavior will be broken. |
While working on (1), I noticed that |
|
Happy to review but it should be a separate PR |
| """ | ||
| run_id = uuid4() | ||
| thread_id = user_input.thread_id or str(uuid4()) | ||
| thread_id = f"{user_input.thread_id or str(uuid4())}-{agent_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thread_id must be uuid4 by langgraph api spec and langchain agent protocol.
This PR separate dialog history of multiple agents.
_handle_input.