Repository navigation
Accept keyword arguments passed by the ControlSystemsBase 1.23 plot recipes for FRD - #202
Merged
Merged
Conversation
…ecipes for FRD The Bodeplot recipe passes balance to bode, and the frequency-vector selection passes adaptive to _default_freq_vector. Both are accepted and ignored for FRD. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ControlSystemsBase v1.23.0 passes
balancetobodein theBodeplotrecipe andadaptiveto_default_freq_vectorwhen selecting the frequency vector. TheFRDmethods did not accept these keyword arguments, sobodeplot(frd)failed withChanges:
bode(::FRD, w; unwrap, kwargs...)and_default_freq_vector(::FRD/::Vector{<:FRD}, _; kwargs...)accept and ignore additional keyword arguments, consistent with the existingfreqresp(::FRD; kwargs...)method.nyquistandsigmause the genericLTISystemmethods, which callfreqrespand therefore required no change.test/test_plots.jlcoveringbode(frd, w; unwrap=false, balance=true),bodeplot(single system and vector),nyquistplotandsigmaplotforFRD. The test fails on master with ControlSystemsBase 1.23.0 and passes with this change;test_frd.jlpasses.Host: demeter2
Working directory: /tmp/claude-7594982/-home-baggepinnen--julia-dev-DyadControlSystems/974120bf-7fce-4326-8ff8-7a0911e29861/scratchpad/CSI
🤖 Generated with Claude Code