Repository navigation
Allow JSON.jl 1.x - #246
Merged
Merged
Conversation
JSON is used to parse the Nanosoldier PkgEval report and to write pkg.json. The parsed report is only indexed, checked with haskey and extended with two URLs before going through TOML.print and JSON.json, all of which behave the same on JSON.Object as on Dict. Widen compat to JSON = "0.21, 1" and test both majors in CI; version 0.8.5.
pfitzseb
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the JSON compat to
JSON = "0.21, 1"so the package can be used in environments that have moved to JSON.jl 1.x. Version 0.8.5.JSON is used in two places:
JSON.parseof the Nanosoldier PkgEvaldb.jsoninget_pkg_eval_data, andJSON.json(meta)when writingpkg.json(run/generate_json.jlalso callsJSON.print, which 1.x keeps). The parsed report is only indexed and checked withhaskey, and the per-package entry is extended withreport_url/log_urlbeforemetagoes throughTOML.printandJSON.json. JSON 1.x returns aJSON.Objectinstead of aDict, which supports all of that. Verified by loading the package against JSON 0.21.4 and 1.8.0, fetching the live report throughget_pkg_eval_data()on each, and running the mutation plusTOML.printandJSON.jsonon the result.CI gains a
jsonmatrix dimension with an explicitPkg.add(JSON@…)pin step, since the resolver alone would only ever exercise one major. Julia 1.9 runs 0.21 only (JSON 1.x needs 1.10).