Repository navigation
Add cconvert for pointers to BlockSkylineMatrix blocks - #251
Merged
Merged
Conversation
For a BlockSkylineMatrix with ragged block bandwidths, block_starts is a BandedMatrix with bandwidths (maximum(l), maximum(u)), so it has in-band slots for blocks that a narrower column does not store. These were allocated undef and never written, so reading them gave garbage. They now read as 0, like the out-of-band entries. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
On Julia nightly, Base defines cconvert for SubArrays of ranges, which bypasses the unsafe_convert overloads here and calls strides on the non-strided parent. Define cconvert for BlockBandedBlock and the three SubBlockSkylineMatrix view types, offsetting a view of A.data. Test the strided interface with check_strided_get and run CI on nightly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
+ Coverage 90.45% 90.76% +0.30%
==========================================
Files 11 11
Lines 1142 1169 +27
==========================================
+ Hits 1033 1061 +28
+ Misses 109 108 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more correct fix compared to #234
On Julia nightly, Base defines
cconvertforSubArrays of ranges, whichbypasses the
unsafe_convertoverloads here.Define
cconvertforBlockBandedBlockand the threeSubBlockSkylineMatrixview types, offsetting a view of A.data.Test the strided interface with
check_strided_getand run CI on nightly.Assisted-by: Claude Code (Opus 5.5)