Skip to content

Explicitly qualify new methods in GB_CHOLMOD#153

Open
JamesWrigley wants to merge 2 commits intomasterfrom
constructors
Open

Explicitly qualify new methods in GB_CHOLMOD#153
JamesWrigley wants to merge 2 commits intomasterfrom
constructors

Conversation

@JamesWrigley
Copy link
Copy Markdown
Member

Should fix these warnings on Julia 1.12:

┌ SuiteSparseGraphBLAS
│  WARNING: Constructor for type "GBVector" was extended in `GB_CHOLMOD` without explicit qualification or import.
│    NOTE: Assumed "GBVector" refers to `SuiteSparseGraphBLAS.GBVector`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function GBVector end`.
│    Hint: To silence the warning, qualify `GBVector` as `SuiteSparseGraphBLAS.GBVector` in the method signature or explicitly `import SuiteSparseGraphBLAS: GBVector`.
│  WARNING: Constructor for type "GBMatrix" was extended in `GB_CHOLMOD` without explicit qualification or import.
│    NOTE: Assumed "GBMatrix" refers to `SuiteSparseGraphBLAS.GBMatrix`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function GBMatrix end`.
│    Hint: To silence the warning, qualify `GBMatrix` as `SuiteSparseGraphBLAS.GBMatrix` in the method signature or explicitly `import SuiteSparseGraphBLAS: GBMatrix`.
│  WARNING: Constructor for type "GBMatrixC" was extended in `GB_CHOLMOD` without explicit qualification or import.
│    NOTE: Assumed "GBMatrixC" refers to `SuiteSparseGraphBLAS.GBMatrixC`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function GBMatrixC end`.
│    Hint: To silence the warning, qualify `GBMatrixC` as `SuiteSparseGraphBLAS.GBMatrixC` in the method signature or explicitly `import SuiteSparseGraphBLAS: GBMatrixC`.
│  WARNING: Constructor for type "GBMatrixR" was extended in `GB_CHOLMOD` without explicit qualification or import.
│    NOTE: Assumed "GBMatrixR" refers to `SuiteSparseGraphBLAS.GBMatrixR`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function GBMatrixR end`.

I couldn't get the package precompiling on my system without 346e143, and when actually importing it I got another error from a missing symbol in some shared library. The tests also didn't run out of the box for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant