Skip to content

Conversation

@nchiru
Copy link

@nchiru nchiru commented Jan 30, 2024

added ifl in out errors and traffic fields

@healthbot-ci
Copy link
Collaborator

Only Juniper employees can contribute to juniper_official folder. If you are one follow the steps mentioned in the README else, contribute to the community_supplied directory. Make the necessary changes and commit again.

description "Subinterface operational status";
}
}
field high-threshold {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to traffic-high-threshold

}
field in-errors-threshold {
constant {
value "{{errors-threshold-variable}}";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot find this variable

path /interfaces/interface/subinterfaces/subinterface/state/counters/in-errors;
zero-suppression;
}
type integer;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be uint?

path /interfaces/interface/subinterfaces/subinterface/state/counters/in-octets;
zero-suppression;
}
type integer;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint?

type float;
description "Utilization in percentage which derived based on mbps and interface speed";
}
field low-threshold {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to traffic-low-threshold

}
field out-errors-threshold {
constant {
value "{{errors-threshold-variable}}";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find this variable

path /interfaces/interface/subinterfaces/subinterface/state/counters/out-octets;
zero-suppression;
}
type integer;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint?

description "Sub interfaces index to be monitored, regular expression, eg '0-10'";
type string;
}
variable traffic-high-threshold {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using thresholds where there are no triggers? What is the porpose here? Only collecting the data without any evaluations????

@sharanyab16
Copy link

Jenkins please retry a build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants