Skip to content

updated lfm discovery state enums and trigger msg #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nchiru wants to merge 2 commits into
base: jcloud
Choose a base branch
from
Open

updated lfm discovery state enums and trigger msg #957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
122f76f
updated lfm discovery state enums and trigger msg
nchiru Jul 31, 2024
9598749
updated lfm discovery state enums and trigger msg
nchiru Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions juniper_official/oam/ethernet-oam-lfm.rule
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,28 @@ healthbot {
}
type string;
description "Discovery state for a given interface";
enumerate "Passive Wait" as 0;
enumerate "Send Any" as 1;
enumerate "Send Local Remote" as 2;
enumerate "Send Local Remote Ok" as 3;
enumerate "Fault" as -1;
enumerate "Active Send Local" as 3;
enumerate "Passive Wait" as 4;
Copy link
Collaborator

@gaddevijay gaddevijay Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change enums for already present states

Copy link
Collaborator

@gaddevijay gaddevijay Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you confirm that state anything > 1 is a good state?

enumerate "Send Local Remote" as 5;
enumerate "Send Local Remote OK" as 6;
enumerate "Send Any" as 7;
enumerate "Lost Link Timer Expired" as -2;
enumerate "Link Down" as 0;
enumerate "Link Up Active" as 1;
enumerate "Link Up Passive" as 2;
enumerate "Info PDU Received" as 8;
enumerate "Info PDU Rcvd & Loc Sat" as 9;
enumerate "Info PDU Rcvd & Loc NotSat" as 10;
enumerate "Info PDU Rcvd & Rem Sat" as 11;
enumerate "Info PDU Rcvd & Rem NotSat" as 12;
enumerate "No Action" as 13;
enumerate "Restart Discovery" as 14;
enumerate "Active Send Local entry" as 15;
enumerate "Passive Wait entry" as 16;
enumerate "Send Local Remote entry" as 17;
enumerate "Send Local Remote OK entry" as 18;
enumerate "Send any entry" as 19;
}
field lfm-status {
sensor link-fault-management-information {
Expand Down Expand Up @@ -67,15 +85,15 @@ healthbot {
then {
status {
color green;
message "$lfm-interface-name LFM discovery-state: $lfm-discovery-state; lfm-status: $lfm-status; lfm-peer-address: $lfm-peer-address";
message "$lfm-interface-name LFM discovery-state: $lfm-discovery-state; lfm-status: $lfm-status";
Copy link
Collaborator

@gaddevijay gaddevijay Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If peer address is not used anywhere can we remove the field? Please confirm with Venakt.

}
}
}
term lfm-discovery-state-remote-unstable {
then {
status {
color red;
message "$lfm-interface-name LFM discovery-state: $lfm-discovery-state; lfm-status: $lfm-status; lfm-peer-address: $lfm-peer-address";
message "$lfm-interface-name LFM discovery-state: $lfm-discovery-state; lfm-status: $lfm-status";
}
}
}
Expand Down