feat: allow user patches on non-paging documents in paintTo#71
Open
OGKevin wants to merge 1 commit into
Open
Conversation
OGKevin
force-pushed
the
khellemun/push/nzznrmyokmpz
branch
2 times, most recently
from
13f3017 to
7b8cf8f
Compare
Refactored ReaderView:paintTo to delegate to the original method for non-paging documents, enabling user patches (such as header/footer patches) to work correctly. Simplified paging logic and improved dithering handling for both paging and non-paging documents. - Save and use the original paintTo for non-paging documents - Only override paintTo for paging documents (PDFs, CBZs, etc.) - Simplify page drawing logic for clarity and maintainability - Adjust dithering logic to respect user settings on paging documents Fixes: #65 Change-Id: c00c8d1bfda0698d663a6045b0930448 Change-Id-Short: nzznrmyokmpz
OGKevin
force-pushed
the
khellemun/push/nzznrmyokmpz
branch
from
7b8cf8f to
e5abfba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored ReaderView:paintTo to delegate to the original method for non-paging documents, enabling user patches (such as header/footer patches) to work correctly. Simplified paging logic and improved dithering handling for both paging and non-paging documents.
Fixes: #65
Change-Id: c00c8d1bfda0698d663a6045b0930448
Change-Id-Short: nzznrmyokmpz