Skip to content

refactor: functional style for collect_option_display_aliases #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KSXGitHub merged 2 commits into from
Mar 28, 2026
Merged

refactor: functional style for collect_option_display_aliases #382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa2b3d1
refactor: functional style for collect_option_display_aliases
Copilot Mar 28, 2026
be33238
refactor: remove `short`
KSXGitHub Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/usage_md.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,17 +166,22 @@ fn write_option_anchors(out: &mut String, arg: &Arg, primary_long: &str) {
}

fn collect_option_display_aliases(arg: &Arg) -> Vec<String> {
let mut aliases = Vec::<String>::new();
if let Some(short) = arg.get_short() {
aliases.push(format!("-{short}"));
}
for alias in arg.get_visible_aliases().unwrap_or_default() {
aliases.push(format!("--{alias}"));
}
for alias in arg.get_visible_short_aliases().unwrap_or_default() {
aliases.push(format!("-{alias}"));
}
aliases
let long_aliases = arg
.get_visible_aliases()
.into_iter()
.flatten()
.map(|alias| format!("--{alias}"));
let short_aliases = arg
.get_visible_short_aliases()
.into_iter()
.flatten()
.map(|alias| format!("-{alias}"));
arg.get_short()
.map(|short| format!("-{short}"))
.into_iter()
.chain(long_aliases)
.chain(short_aliases)
.collect()
}

fn collect_option_default_values(arg: &Arg) -> Vec<Cow<'_, str>> {
Expand Down
Loading