Align JMS XA examples with KaotoIO/forage#427 endpoint contract - #30
Draft
Croway wants to merge 1 commit into
Draft
Align JMS XA examples with KaotoIO/forage#427 endpoint contract#30Croway wants to merge 1 commit into
Croway wants to merge 1 commit into
Conversation
With forage.jms.transaction.enabled=true, Forage now wires a JtaTransactionManager into the Camel JMS component; endpoints must not enable local JMS transactions (transacted=true) on XA connections - IBM MQ rejects them with MQRC 2072. Also documents that the transactions example needs PostgreSQL started with max_prepared_transactions > 0: a JMS+JDBC transaction is a real two-phase commit once JMS properly enlists in JTA, previously masked by the one-phase-commit optimization when only the JDBC branch participated. Requires a Forage release containing KaotoIO/forage#430 (fixes #427).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forage.jms.transaction.enabled=true, Forage now wires aJtaTransactionManagerinto the Camel JMS component; endpoints must not enable local JMS transactions (transacted=true) on XA connections - IBM MQ rejects them with MQRC 2072.transactionsexample needs PostgreSQL started withmax_prepared_transactions > 0: a JMS+JDBC transaction is a real two-phase commit once JMS properly enlists in JTA, previously masked by the one-phase-commit optimization when only the JDBC branch participated.Depends on
Requires a Forage release containing KaotoIO/forage#430 (fixes #427). This PR is opened as a draft and should only be merged once that Forage PR is merged and a Forage build containing it is available.
Test plan
jms/transactionalverified end-to-end: clean commit path, rollback showsredelivered(false)thenredelivered(true)on retry, no more spurious "session already closed" warnings.transactionsverified end-to-end against Postgres started withmax_prepared_transactions=100: OK transactions commit and are visible in thetesttable; ROLLBACK transactions are correctly absent.