feat: optional centralized Luigi scheduler + dispatch_id for hermes w…#934
Merged
Conversation
…orkflows (#918) Move hermes workflow execution off the hardcoded --local-scheduler to an optional centralized scheduler, and propagate a unique dispatch_id to every Luigi node so the central scheduler (which keys on task family + parameters) can tell distinct runs apart. - buildLuigiExecutionCommand helper builds local/central invocations and the --dispatch-id flag, shared by both execution call sites. - executeWorkflowFromDB / LSM addWorkflowToGroup / OF runOFSimulation accept scheduler, schedulerHost, schedulerPort, dispatch_id (auto uuid4, logged). - hera-workflows buildExecute CLI gains --scheduler/--scheduler-host/ --scheduler-port/--dispatch-id, forwarded through workflow_buildExecute. - Add test_workflow_execution.py covering the command builder and template. Requires the matching hermes change (dispatch_id luigi.Parameter on nodes). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…paths (#918) The OpenFOAM CLI executes workflows via hermes handler_buildExecute, a path separate from executeWorkflowFromDB. Add the scheduler-selection and dispatch_id flags to its executeWorkflow/buildExecute subparsers so the centralized scheduler option reaches those runs too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The template lives in hermes; hera CI vendors hermes' default branch, which does not carry the dispatch_id change until the hermes PR merges, so a hera-side assertion on the template fails in CI. Keep only the hera command-builder tests here; the template is tested in the hermes repo. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…918) Builds and executes the Tutorial workflow through hera's buildLuigiExecutionCommand and asserts the run completes with per-dispatch output isolation. Guarded to skip when hermes/luigi are unavailable or the vendored hermes predates the dispatch_id node template change, so it stays green until the hermes PR merges and activates automatically afterwards. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…orkflows (#918)
Move hermes workflow execution off the hardcoded --local-scheduler to an optional centralized scheduler, and propagate a unique dispatch_id to every Luigi node so the central scheduler (which keys on task family + parameters) can tell distinct runs apart.
Requires the matching hermes change (dispatch_id luigi.Parameter on nodes).