Conversation
Move buildWorkflowEdges and isValidConnection (and the WorkflowEdge type) out of workflowLayout into a dedicated workflowEdges module, leaving workflowLayout to positioning only. Tests split to match.
Server endpoint GET /node-catalog (ui/server/node_catalog.py) lists Hermes node types + their parameters from the vendored node_lookup. The node `type` field becomes a domain-grouped autocomplete that prefills input_parameters on selection.
Stack and de-overlap workflow nodes by their real measured heights, pushing down only the nodes that actually collide so a node that grew (e.g. after picking a type) no longer overlaps the ones below it. Move the placement logic into a WorkflowLayout class (WorkflowLayout.ts) over the geometry helpers (workflowGeometry.ts, renamed from workflowLayout.ts).
Warn on a node when its type isn't in the catalog or a required parameter is empty (validateNode). Show problems below the params with a warning-tinted border; never blocks editing. Covered by unit tests.
Add a generic, recursive FieldDef ({ required, children }) threaded through
the
details tree as one `def` prop. Required node params now show MUI error +
helperText="required" under the empty field; nodeTypeIssue keeps the type
warning. paramsFieldDef maps the Hermes catalog to FieldDef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.