fix(ci): validate Windows PE stack reserve at correct offset - #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows release binary verification step that rejected the
v1.4.0-rc.1build.The check read
SizeOfStackReserve48 bytes into the PE32+ optional header. The field starts at offset 72 and is 8 bytes wide, so the check read0x6from the subsystem version fields instead of the configured0x1000000stack reserve. The bounds check now covers the complete field too.Failure: https://github.com/Karib0u/rustinel/actions/runs/33099209766/job/98613963790
Type of change
bug- bug fixci- CI and release changesTest plan
git diff --checkChecklist
After this merges, the existing
v1.4.0-rc.1tag must be recreated on the fixed commit so the release workflow uses the corrected verification step.