Feat power button #351
Open
Feat power button #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparchatus
force-pushed
the
feat_power_button
branch
from
2aa4248 to
e98fd0c
Compare
wipawel
requested changes
Nov 13, 2025
minipli-oss
reviewed
Nov 13, 2025
sparchatus
force-pushed
the
feat_power_button
branch
2 times, most recently
from
155fb4d to
114c5ad
Compare
Driver for ACPI fixed power buttons. It allows overwriting the default handler so the button can be used for custom purposes. One such purpose might be to trigger an experiment to run. Signed-off-by: Sandro Rüegge <[email protected]>
sparchatus
force-pushed
the
feat_power_button
branch
from
114c5ad to
405cb93
Compare
Contributor
Author
|
I have removed the spinlock changes. I have added another commit that adds a |
Adding a self reference to the percpu allows checking what CPU some code is currently running on. We use this in pb_set_handler to ensure it runs on the bsp.
Signed-off-by: Sandro Rüegge <[email protected]>
sparchatus
force-pushed
the
feat_power_button
branch
from
405cb93 to
9b2fae1
Compare
minipli-oss
reviewed
Nov 15, 2025
|
|
||
| static void default_handler(void *); | ||
|
|
||
| spinlock_t pb_handler_lock = SPINLOCK_INIT; |
Contributor
There was a problem hiding this comment.
pb_handler_lock isn't used any more, can remove its definition as well.
minipli-oss
requested changes
Nov 15, 2025
| unsigned long usermode_private; | ||
| volatile unsigned long apic_ticks; | ||
| bool apic_timer_enabled; | ||
| struct cpu *cpu; |
Contributor
There was a problem hiding this comment.
I guess, using the proper typedef'd type cpu_t would cause a cyclic header include dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ACPI fixed power buttons. This is based on #350
I wanted to add the functionality to change the power button handler because it would be useful for triggering experiments for me. This opened up a race condition between the interrupt and the function changing the handler. The interrupt may not wait for a spinlock so I added a try_lock function but I am not very convinced by this approach.