Remove non-blocking TODOs from LEMS-4354 - #4077
Merged
Merged
Conversation
Contributor
npm SnapshotWant to try this PR's changes before it merges? Comment |
Contributor
|
Size Change: 0 B Total Size: 519 kB ℹ️ View Unchanged
|
benchristel
commented
Aug 13, 2026
Member
Author
There was a problem hiding this comment.
The final task in fixie's checklist was to search for TODOs related to LEMS-4354 and make sure they're all resolved. The planned work is complete now, so the plan file can be deleted.
jeremywiebe
approved these changes
Aug 13, 2026
handeyeco
approved these changes
Aug 13, 2026
benchristel
force-pushed
the
benc/widget-props-3
branch
from
August 13, 2026 22:36
9f92148 to
d45c6ae
Compare
benchristel
requested review from
catandthemachines,
ivyolamit and
nishasy
as code owners
August 13, 2026 22:36
Base automatically changed from
benc/widget-props-3
to
benc/widget-props-redesign
August 13, 2026 22:49
benchristel
force-pushed
the
benc/widget-props-4
branch
from
August 13, 2026 22:50
c9cf20d to
1f21194
Compare
benchristel
added a commit
that referenced
this pull request
Aug 13, 2026
## Summary: This PR does final cleanup for the WidgetProps migration. - Making the Numeric Input's `labelText` required is out of scope for this migration. - The `dependencies` prop that some widgets receive is passed via a HOC, not via the Renderer/WidgetContainer. Therefore, it shouldn't be part of `WidgetProps`. Issue: LEMS-4354 ## Test plan: CI checks should pass. Author: benchristel Reviewers: benchristel, jeremywiebe, handeyeco, nishasy, ivyolamit, Myranae, catandthemachines Required Reviewers: Approved By: jeremywiebe, handeyeco Checks: ✅ 10 checks were successful Pull Request URL: #4077
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR does final cleanup for the WidgetProps migration.
labelTextrequired is out of scope for this migration.dependenciesprop that some widgets receive is passed via a HOC, not via theRenderer/WidgetContainer. Therefore, it shouldn't be part of
WidgetProps.Issue: LEMS-4354
Test plan:
CI checks should pass.