(janitor/dedupe): share default user notification preferences

[kilo-code-bot]

Summary

The all-enabled UserNotificationPreferences default value was declared three times across the notifications service — twice as a local DEFAULT_PREFERENCES constant and once as an inlined object literal. This consolidates them onto a single exported DEFAULT_USER_NOTIFICATION_PREFERENCES constant.

cloud-agent-session-push.ts already owns the UserNotificationPreferences type (and sanitizeTitle), so it is the natural authoritative owner for the default value. The two other modules already import from it, so no dependency changes are introduced.

Scope

• cloud-agent-session-push.ts: exports DEFAULT_USER_NOTIFICATION_PREFERENCES and replaces its inlined default object.
• agent-session-notification-push.ts: removes its local DEFAULT_PREFERENCES, imports the shared constant.
• internal-dispatch-push.ts: removes its local DEFAULT_PREFERENCES, imports the shared constant.

No behavioral change.

Verification

• pnpm --filter notifications typecheck — clean
• pnpm --filter notifications test — 217 passed
• oxlint on services/notifications/src — 0 warnings, 0 errors
• oxfmt --list-different on changed files — clean

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• services/notifications/src/lib/agent-session-notification-push.ts
• services/notifications/src/lib/cloud-agent-session-push.ts
• services/notifications/src/lib/internal-dispatch-push.ts

---

_{Reviewed by grok-4.6 · Input: 82.6K · Output: 5.2K · Cached: 187.1K}

_{Review guidance: REVIEW.md from base branch main}