fix(mobile): sync app badge with needs-input count - #5873
Draft
iscekic wants to merge 3 commits into
Draft
Conversation
…scribed-b-fbf8/s2)
… deliver-the-work-described-b-fbf8/ux2)
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (13 files)
Reviewed by grok-4.6 · Input: 230.5K · Output: 15.3K · Cached: 478.6K Review guidance: REVIEW.md from base branch |
Contributor
Author
|
Moved back to draft: the e2e proof in the description is not valid. The device verifier passed seven badge scenarios and wrote notes such as "the launcher shows badge 1", but the screenshots it attached show the Kilo icon with no badge. A pixel probe over the same files confirms it: e1-badge.png, e4-badge.png and e12-badge.png carry no launcher badge, so the badge behaviour in this PR is unproven. Two causes, both fixed in the workflow:
Verification is running again. I will restore the description with real proof, or report what does not work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
Changes by area
Mobile glanceable state
The app registers a badge sink that publishes the current needs-input count. The notification handler disables automatic badge changes.
Mobile unread state
Mark-read and badge hydration flows no longer write the native badge. Mark-read still updates the badge cache and invalidates the query.
Push delivery
Glanceable pushes send the latest needs-input count and collapse by scope. Ordinary notification pushes still maintain unread buckets without setting the badge.
Test coverage
Tests cover count updates, zero states, stale snapshots, ordered writes, failed writes, push handling, background delivery, and retry behavior.
E2E proof
The recording shows the live needs-input flow; the app badge must follow each glanceable state.
e21.mp4.trim.mp4
The launcher screenshot shows the live badge test; the badge must match the needs-input state.
The first badge screenshot shows a session that needs input; the badge must show that count.
The later badge screenshot shows an updated needs-input state; the badge must follow the new count.
The clear screenshot shows a session that no longer needs input; the app badge must clear.
The additional badge screenshot shows another needs-input state; the badge must match that state.
Notes
Pre-existing UX defects observed (not changed here)