fix(cloud-agent-next): release unadmitted queued messages on quarantine - #5920
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryQuarantine release still drops leftover attach proofs so replacement drain can retry unadmitted messages; no remaining issues on current HEAD. Files Reviewed (3 files)
Previous Review Summaries (6 snapshots, latest commit d331d9e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d331d9e)Status: No Issues Found | Recommendation: Merge Executive SummaryQuarantine release drops leftover attach proofs so replacement drain can retry unadmitted messages; no remaining issues on current HEAD. Files Reviewed (3 files)
Previous review (commit ee70bfe)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental change only removes the control-plane retry plan doc; no remaining issues on current HEAD. Files Reviewed (1 files)
Previous review (commit 95fbae6)Status: No Issues Found | Recommendation: Merge Executive SummaryQuarantine release drops leftover attach proofs so replacement drain can retry unadmitted messages; no remaining issues on current HEAD. Files Reviewed (4 files)
Previous review (commit 5770e3f)Status: No Issues Found | Recommendation: Merge Executive SummaryQuarantine release drops leftover attach proofs so replacement drain can retry unadmitted messages; no remaining issues on current HEAD. Files Reviewed (4 files)
Previous review (commit 14244c1)Status: No Issues Found | Recommendation: Merge Executive SummaryQuarantine release now drops leftover attach proofs, so replacement drain can retry unadmitted messages; no remaining issues in the incremental fix. Files Reviewed (2 files)
Previous review (commit eb9ca56)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 114K · Output: 13K · Cached: 487.8K Review guidance: REVIEW.md from base branch |
14244c1 to
5770e3f
Compare
5770e3f to
95fbae6
Compare
ee70bfe to
d331d9e
Compare
d331d9e to
af667f9
Compare
Summary
wrapperInstanceIdso the replacement runtime can pick them up through the normal queue drain.Stack
Remaining control-plane recovery stack. #5912–#5918 are merged. Merge from the bottom.
eshurakov/recovery-stack→maineshurakov/recovery-not-ready-retry→eshurakov/recovery-stackeshurakov/recovery-cold-bootstrap-attach→eshurakov/recovery-not-ready-retryeshurakov/ca-stable-workspace-tabs→eshurakov/recovery-cold-bootstrap-attachReviewer Notes
One commit. Unique vs parent.
Live local E2E did not prove replacement completion: killing only the primary left the proxy up, so
pendingRuntimeCleanupblocked later dispatch untilpreparation_timeout. That stop-lifecycle gap is out of scope here. This PR covers the originalkilo_unhealthyunadmitted-queue incident path.