fix(extension): keep model picker search bar pinned while the model list scrolls - #5924
Merged
Merged
Conversation
…ist scrolls In the web extension model picker, keep the search bar pinned to the top of the list while the model list scrolls under it. The search field must stay visible and usable at every scroll position, keep its focus and typed text while scrolling, and must not overlap the first row or clip the list. Reproduce the current behaviour first (record the search bar scrolling out of view), then fix it and prove the fix on the same live picker with a recording that scrolls a long model list.
eshurakov
approved these changes
Sep 7, 2026
marius-kilocode
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request
Changelog for users
Changelog for maintainers
apps/extension/entrypoints/sidepanel/model-picker.tsx: it is nowsticky top-14 z-10withbg-surface-background; thetop-14offset must keep matching the dialog header'sh-14height, so change the two together.overflow-y-autoscroll container; splitting the dialog into separate scroll panes detaches the bar.apps/extension/entrypoints/sidepanel/model-picker.test.tsxpin the sticky contract via classes (jsdom has no layout engine andscrollIntoViewis stubbed) and assert focus plus typed text survive a programmatic scroll; they cannot catch pixel-level overlap, which is what the live-picker captures cover.E2E proof