fix(mobile): start voice input in the device language when its offline speech model is missing - #5925
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Previous Review Summary (commit c5b1ba2)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c5b1ba2)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (94 files)
Reviewed by grok-4.6 · Input: 65.4K · Output: 14.2K · Cached: 473K Review guidance: REVIEW.md from base branch |
iscekic
marked this pull request as draft
September 7, 2026 05:59
…e speech model is missing #5925
iscekic
force-pushed
the
kwf/voice-input-fails-on-a-germa-f790
branch
from
September 7, 2026 08:42
1d2c141 to
b1b03d5
Compare
iscekic
marked this pull request as ready for review
September 7, 2026 10:42
marius-kilocode
approved these changes
Sep 7, 2026
eshurakov
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request
Changelog for users
Changelog for maintainers
requiresOnDeviceRecognitionwas set for a language whose offline model was missing and every start failed withlanguage-not-supported. The refined gate lives inapps/mobile/src/lib/voice-input/use-voice-input-actions.ts(supportsOnDevice= service supports on-device AND the resolved language is installed) — start the review there.apps/mobile/src/lib/voice-input/voice-input-language.tsnow cacheslocalestogether withinstalledLocalesfromgetSupportedLocales, and adds the per-language gate, an endonym display name (de-DE→ 'Deutsch') for the alert copy, andinvalidateVoiceRecognitionLocalesCache(); the invalidation after a download trigger is load-bearing — without it the gate would serve the stale pre-download list for the rest of the session.androidTriggerOfflineModelDownload; if that path is reached on iOS the rejection lands in the catch and shows the actionable toast, but the alert itself is platform-blind — worth a look.unavailableLanguagecopy change is asserted in the two error-classification suites.E2E proof
[e1] Prove the fix live on the same German-locale emulator with a recording, and show English still works after the change. — android emulator-5554: app language Deutsch; mic showed disclosure 'Sprachaufnahmen werden online verarbeitet' with NICHT JETZT/ERLAUBEN (e1-tap-mic-de.png, e1-disclosure.log), then listening 'Aufnahme läuft …' / 'Spracheingabe beenden' (e1-erlauben-listen.png, e1-de-listen.log). After switching to English, Start voice input reached Listening (e1-english-mic.png, e1-en-listen.log). Recording e1-voice-de-en.mp4. Declined-consent download alert not exercised (consent granted; no e2e consent hook). UX: disclosure and listening labeled with next actions; no UX-DEFECT.
e1-voice-de-en.mp4.trim.mp4
Follow-ups (not changed here)