(janitor/test-prune): remove tautological constant and type-shape assertions - #5928
Open
kilo-code-bot[bot] wants to merge 1 commit into
Open
(janitor/test-prune): remove tautological constant and type-shape assertions#5928kilo-code-bot[bot] wants to merge 1 commit into
kilo-code-bot[bot] wants to merge 1 commit into
Conversation
Remove tests that re-list exported constants or assert a locally constructed type shape, so they cannot detect any production regression: - remote-command-catalog.test.ts: the RemoteCommandState block built a literal object and asserted Array.isArray on it; RemoteCommandState is a pure TypeScript type with no runtime surface to exercise. - deadline.test.ts: CONTROL_PLANE_DEADLINE_MS / SEND_DEADLINE_MS blocks re-stated the exported literal constants; behavior is already covered by the withDeadline suite. - dolthub/api.test.ts: the constants block re-stated DOLTHUB_API_BASE / DOLTHUB_WEB_BASE; buildDoltUrl and doltFetch tests already exercise the base URL indirectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes four test blocks that re-list exported constants or assert a locally-constructed type shape, so they cannot detect any plausible production regression. 47 lines removed, no production code touched.
Removed tests and surviving coverage
packages/cloud-agent-sdk/src/remote-command-catalog.test.ts—describe('RemoteCommandState')commands: [] as never[]) and assertsArray.isArrayon it.RemoteCommandStateis a pure TypeScript type with no runtime export; the test never exercises production code.tsgo. The parser behind the state (parseRemoteCommandCatalog/remoteCommandCatalogV1Schema) is covered by the remaining tests in the same file.packages/event-service/src/__tests__/deadline.test.ts—CONTROL_PLANE_DEADLINE_MS/SEND_DEADLINE_MS15_000/30_000); any change must edit both the constant and the test in lockstep, so the assertion adds no behavioral protection.withDeadlineandRequestDeadlineErrorsuites exercise the actual deadline behavior.packages/wl-sdk/src/dolthub/api.test.ts—describe('constants')DOLTHUB_API_BASE/DOLTHUB_WEB_BASEliterals.buildDoltUrlanddoltFetchtests already exerciseDOLTHUB_API_BASEindirectly through URL construction; the constants remain exported and referenced.Validation
event-service/deadline.test.ts(20→18),wl-sdk/dolthub/api.test.ts(12→11),cloud-agent-sdk/remote-command-catalog.test.ts(19→18) — all green after removal.oxlinton the three files: 0 warnings, 0 errors.tsgo --noEmiton all three packages: clean.No postgres/redis needed — all three suites are pure unit tests.