-
Notifications
You must be signed in to change notification settings - Fork 1.5k
ci: Enable verbose test output in GitHub Actions #4588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Modified vitest-verbosity.ts to detect CI environment and use verbose reporter - Updated vitest configs for packages/types, packages/cloud, and packages/telemetry - Tests now use verbose reporter in CI for better debugging - Local development experience remains unchanged with dot reporter
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No Issues Found
4 files reviewed | Confidence: 95% | Recommendation: Merge
Review Details
Files:
src/utils/vitest-verbosity.ts- CI detection added to shared utilitypackages/cloud/vitest.config.ts- Inline CI detection addedpackages/telemetry/vitest.config.ts- Inline CI detection addedpackages/types/vitest.config.ts- Inline CI detection added
Checked: Security, bugs, logic correctness, consistency
Notes:
- CI detection logic is consistent across all files:
process.env.CI === "true" || process.env.CI === "1" || Boolean(process.env.CI) src/vitest.config.tsandwebview-ui/vitest.config.tsalready useresolveVerbosity()and will automatically benefitcli/vitest.config.tsalready uses verbose reporter by default (no changes needed)- Minor observation: Local fallback differs between
resolveVerbosity()(uses"dot") and package configs (use"default"), but both are valid choices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ No New Issues
Changes since last review (commit 796805b) look good.
Latest commit (a394bd4): Removed cloud package changes and added kilocode_change markers - cosmetic/organizational changes only.
Review Details (3 files)
Files reviewed:
src/utils/vitest-verbosity.ts- Added comment markerspackages/telemetry/vitest.config.ts- Added comment markerspackages/types/vitest.config.ts- Added comment markers
Checked: Security, bugs, logic correctness
Notes: CI detection logic remains consistent and correct across all files.
Summary
This PR modifies the test configuration to use verbose output in CI/PR workflows while keeping the local development experience unchanged.
Changes
vitest-verbosity.tsto detect CI environment and automatically use verbose reporterpackages/types,packages/cloud, andpackages/telemetryto use verbose reporter in CIsrc,webview-uialready use the vitest-verbosity utility and will automatically get verbose output in CIclialready uses verbose reporter by defaultBehavior
--reporter=verboseflag locally if neededTesting
The changes detect the
CIenvironment variable which is automatically set by GitHub Actions. All test workflows in.github/workflows/code-qa.ymlwill benefit from this change.Fixes the issue where test failures in CI don't provide enough detail to debug.