Webpack Public Path to import 'itk-vtk-viewer' downstream #485
Open
PaulHax wants to merge 2 commits intoKitware:masterfrom
Open
Webpack Public Path to import 'itk-vtk-viewer' downstream #485PaulHax wants to merge 2 commits intoKitware:masterfrom
PaulHax wants to merge 2 commits intoKitware:masterfrom
Conversation
thewtex
approved these changes
May 17, 2022
|
Any idea when this branch will be released? It works great on my Vite app as described |
Contributor
|
If I recall correctly, there were other deployment scenario's where this configuration needed to be verified and possibly did not work? It may take some work to rebase this on HEAD. Instead, we will do better by migrating to itk-wasm 1.0, which is improving webassembly asset configuration to runtime-calls instead of the build-time configurations. ~1 month time frame. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use the pre-built itk-vtk-viewer bundle as a upstream dependency we:
''(document relative) rather than the defaultauto. publicPath asautocaused aautomatic publicpath is not supported in this browsererror when including itk-vtk-viewer in the bundle.This change allows for a vite project to
With a
vite.config.jslike thisStill have to lift up the pipeline.worker.js and the .wasms =(
Inspired by #475