Fixed main thread checker errors. - #21
Open
MussaCharles wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue which can be reproduced by the following steps:
Product -> Scheme -> Edit Scheme -> Diagnostics -> Runtime API Checking
Then Check MainThreadChecker check checkbox as shown on the following screenshot below.
Run the app
The following main thread errors will be observed
Additionally, I have addressed one of the issue which might occur when using
websiteDataStore.httpCookieStore, which requires to be used on the main thread,To fix the issue, I simply Dispatched calls to
websiteDataStore.httpCookieStore.to the main queue and dispatched a call toURLAuthenticationChallengeto the background thread. This effectively resolved the mentioned issues.Feel free to add or request any necessary changes before merging thanks :)