add env test cases for adopting consumers and credentials #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
test/envtest_adopting_consumers_credentials
branch
from
2147267 to
3f4ecfc
Compare
Member
tao12345666333
left a comment
tao12345666333
left a comment
There was a problem hiding this comment.
There is some repetitive code. I think we can simplify it by creating a function.
randmonkey
force-pushed
the
test/envtest_adopting_consumers_credentials
branch
from
ee31754 to
529b118
Compare
randmonkey
force-pushed
the
test/envtest_adopting_consumers_credentials
branch
from
529b118 to
a3553b5
Compare
pmalek
approved these changes
Nov 25, 2025
Comment on lines
+1428
to
+1434
| Adopt: &commonv1alpha1.AdoptOptions{ | ||
| From: commonv1alpha1.AdoptSourceKonnect, | ||
| Mode: commonv1alpha1.AdoptModeOverride, | ||
| Konnect: &commonv1alpha1.AdoptKonnectOptions{ | ||
| ID: jwtID, | ||
| }, | ||
| }, |
Member
There was a problem hiding this comment.
This is OK to be used as is in this PR but I think we can extract this to a generate function in a separate PR and refactor all the usages of AdoptOptions to use that new function. WDYT?
| "HMAC credential should get the Programmed condition", | ||
| ) | ||
| }) | ||
|
|
| t.Log("Creating a KongCredentialBasicAuth to adopt the BasicAuth") | ||
| createdBasicAuth := &configurationv1alpha1.KongCredentialBasicAuth{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| GenerateName: "basic-auth", |
Member
There was a problem hiding this comment.
Suggested change
| GenerateName: "basic-auth", | |
| GenerateName: "basic-auth-", |
| t.Log("Creating a KongCredentialACL to adopt the ACL") | ||
| createdACL := &configurationv1alpha1.KongCredentialACL{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| GenerateName: "acl", |
Member
There was a problem hiding this comment.
Suggested change
| GenerateName: "acl", | |
| GenerateName: "acl-", |
| t.Log("Creating a KongCredentialHMACAuth to adopt the existing HMAC auth") | ||
| createdHMACAuth := &configurationv1alpha1.KongCredentialHMAC{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| GenerateName: "hmac", |
Member
There was a problem hiding this comment.
Suggested change
| GenerateName: "hmac", | |
| GenerateName: "hmac-", |
| t.Log("Creating a KongCredentialJWT for adopting the existing JWT auth") | ||
| createdJWT := &configurationv1alpha1.KongCredentialJWT{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| GenerateName: "jwt", |
Member
There was a problem hiding this comment.
Suggested change
| GenerateName: "jwt", | |
| GenerateName: "jwt-", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Test adopting
KongConsumerand allKongCredential*entities in envtest.Which issue this PR fixes
Part of #2545
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes