feat(gateway): add Gateway spec.infrastructure.parametersRef support #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for merging GatewayConfiguration objects and handling `spec.infrastructure.ParametersRef` in Gateway resources. Removed unused error `ErrObjectMissingParametersRef`. Refactored to enhance Gateway configuration retrieval.
…ayConfigForParametersRef
mlavacca
reviewed
Nov 21, 2025
Member
mlavacca
left a comment
mlavacca
left a comment
There was a problem hiding this comment.
Mostly lgtm, I've left a couple of comments inline
config/samples/gateway-hybrid-with-gatewayconfiguration-and-per-gateway-infrastructure_v2.yaml
Outdated
Show resolved
Hide resolved
config/samples/gateway-hybrid-with-gatewayconfiguration-and-per-gateway-infrastructure_v2.yaml
Show resolved
Hide resolved
… a Gateway with a custom one
sandromodarelli
force-pushed
the
support-spec-infrastructure-parametersRef-on-gateway
branch
from
c931f13 to
598efde
Compare
mlavacca
approved these changes
Nov 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
sandromodarelli
deleted the
support-spec-infrastructure-parametersRef-on-gateway
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for per-Gateway infrastructure configuration GEP-1867 by handling
spec.infrastructure.ParametersRefin Gateway resources and merging GatewayConfiguration objects using strategic merge patch.Removed unused error
ErrObjectMissingParametersRef.Refactored to enhance Gateway configuration retrieval.
Which issue this PR fixes
Fixes #120
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes