Open
Inline ColumnFilter typealias in public API function signatures#2003
Conversation
Copilot
AI
changed the title
[WIP] Inline ColumnFilter typealias in public API
Inline ColumnFilter typealias in public API function signatures
Jul 28, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
Copilot made a mess... I'll solve it manually |
Jolanrensen
force-pushed
the
copilot/inline-columnfilter-typealias
branch
from
July 29, 2026 11:53
4bf021c to
8a2c78e
Compare
Jolanrensen
force-pushed
the
copilot/inline-columnfilter-typealias
branch
from
July 29, 2026 11:53
8a2c78e to
6e4dc68
Compare
Jolanrensen
marked this pull request as ready for review
July 29, 2026 11:53
Collaborator
|
Okay, |
Collaborator
We can keep them |
Collaborator
Jolanrensen
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ColumnFilter<T>is a trivial single-use alias for(ColumnWithPath<T>) -> Boolean. IDE autocomplete was showing it asColumnFilter<*> /* = (ColumnWithPath<*>) -> Boolean */— noisier than just the expanded type. Aliases where the type parameter appears twice (e.g.RowExpression<T, R>,ColumnsSelector<T, C>) are left intact as they carry structural information.Changes
cols,colsAtAnyDepth,colsInGroups,colsOf,colsOfKind,all,drop,filter,first,last,single,take): replacedColumnFilter<C>/ColumnFilter<*>parameter types with(ColumnWithPath<C>) -> Boolean/(ColumnWithPath<*>) -> Booleanin public function signatures only.ColumnFilter— the typealias is preserved and internal casts (predicate as ColumnFilter<*>) are unchanged.[ColumnFilter]are retained for documentation.import org.jetbrains.kotlinx.dataframe.columns.ColumnWithPathto files that didn't already have it.core/generated-sources/) regenerated via./gradlew :core:processKDocsMain.Before:
After: