Repository navigation
fix: prepend dash to METRICS_WORKLOAD_SUFFIX default in entrypoint.sh - #1008
Merged
Merged
Conversation
Signed-off-by: emmaaroche <eroche@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gateway traffic metrics displaying "-" instead of real numbers in older RHCL versions using console plugin v0.4.x.
Investigated with @Anton-Fil
Problem
The bash heredoc in
entrypoint.shuses${METRICS_WORKLOAD_SUFFIX:-openshift-default}where the:-operator consumes the leading dash from the default value, producing'openshift-default'instead of'-openshift-default'in config.js.This breaks metric lookups:
namespace/gateway-name+openshift-default=namespace/gateway-nameopenshift-defaultsource_workload="gateway-name-openshift-default"Solution
Change line 8 to use double dash:
${METRICS_WORKLOAD_SUFFIX:--openshift-default}The first dash belongs to the
:-operator, the second dash is part of the default value.Affected Versions
Older RHCL releases shipping console plugin v0.4.x with nginx + entrypoint.sh.
Testing
Same fix verified on release-0.6 (v0.6.0) - identical entrypoint.sh logic.
Before fix:
After fix:
Related