Skip to content

Use ClusterFirstWithHostNet for DNS#14

Open
blampe wants to merge 1 commit intoKunde21:masterfrom
blampe:cluster-first
Open

Use ClusterFirstWithHostNet for DNS#14
blampe wants to merge 1 commit intoKunde21:masterfrom
blampe:cluster-first

Conversation

@blampe
Copy link
Copy Markdown

@blampe blampe commented Jun 8, 2022

Functional changes:

  • Use dnsPolicy: ClusterFirstWithHostNet. This enables the plugin to consume a MFS leader hosted on the K8S cluster, e.g. leader.moosefs.svc.cluster.local. Currently, we can only consume leaders hosted on bare metal.

Housekeeping:

  • Adds an explicit v3.0.116-v0.1.1 tag to images -- otherwise containers would crash due to the absence of a latest tag.
  • Modifies CSI containers to use official (+multi-platform) sig-storage images.
  • Modifies RBAC to include volumeattachments/status.

allowPrivilegeEscalation: true
image: kunde21/moosefs-csi
args :
image: kunde21/moosefs-csi:v3.0.116-v0.1.1
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I left this without a tag is to encourage users to check their moosefs version before deploying this plugin. Also, it's quicker/easier to configure both of the image tags in one shot using kustomize

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kunde21 I was shooting for something that just works out of the box. Coincidentally, I think installing via the kustomize directory today would give you 3.0.115 instead of the 3.0.116 tag here.

Unrelated, but re: this part of the change

Modifies CSI containers to use official (+multi-platform) sig-storage images.

This actually broke things significantly. It's been a while but I think I was seeing connections to volumes drop and then never re-mount. It looks like #2 might have resolved that via your custom CSI images, but I couldn't find the source for those. Do you still have that handy? I might be interested in helping with snapshot support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants