Skip to content

Fix: PowerShell command action params / PowerShell sensor encoding fix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amadeo-alex wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix: PowerShell command action params / PowerShell sensor encoding fix #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9de9c73
poc
amadeo-alex Jul 14, 2023
e5ff1e1
added precheck for application message being null/empty (for cases wh…
amadeo-alex Jul 14, 2023
8c6e143
added check for edge case where OEMCodePage returns "1"
amadeo-alex Sep 11, 2023
239fa70
changed fallback from utf-16 to utf-8
amadeo-alex Sep 11, 2023
0a540f8
added multi-step way to parse proper text encoding with fallback to U…
amadeo-alex Sep 15, 2023
bad8c50
cleanup
amadeo-alex Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/HASS.Agent.Staging/HASS.Agent.Shared/HomeAssistant/Commands/PowershellCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public override void TurnOn()
}

var executed = _isScript
? PowershellManager.ExecuteScriptHeadless(Command)
? PowershellManager.ExecuteScriptHeadless(Command, string.Empty)
: PowershellManager.ExecuteCommandHeadless(Command);

if (!executed) Log.Error("[POWERSHELL] [{name}] Executing {descriptor} failed", Name, _descriptor, Name);
Expand All @@ -57,12 +57,9 @@ public override void TurnOnWithAction(string action)
{
State = "ON";

// prepare command
var command = string.IsNullOrWhiteSpace(Command) ? action : $"{Command} {action}";

var executed = _isScript
? PowershellManager.ExecuteScriptHeadless(command)
: PowershellManager.ExecuteCommandHeadless(command);
? PowershellManager.ExecuteScriptHeadless(Command, action)
: PowershellManager.ExecuteCommandHeadless(Command);

if (!executed) Log.Error("[POWERSHELL] [{name}] Launching PS {descriptor} with action '{action}' failed", Name, _descriptor, action);

Expand Down
Loading