[#5][#6] Add UniformCheckpointing class; Update cuSZp compressor.#7
Open
brunoortega wants to merge 2 commits into
Open
[#5][#6] Add UniformCheckpointing class; Update cuSZp compressor.#7brunoortega wants to merge 2 commits into
brunoortega wants to merge 2 commits into
Conversation
This was referenced May 26, 2026
maltempi
requested changes
May 28, 2026
Collaborator
maltempi
left a comment
There was a problem hiding this comment.
Thank you so much for collaborating on this project, Bruno!
I just tested on my toy example, and cuSZp works fine! ✅ I'll add your 2d and 3d into consideration in a new GH issue to keep track of it in the future. Thanks for this advice as well!
Please, take a look at the comments I left on this PR about the Uniform implementation. I'm fine with both solutions: fix the # of checkpoints method or change the getAction() method. It will depend on the time you have available to do it =)
Thank you!
Author
|
PR updated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uniform Checkpointing added.
cuSZp updated from version 1.1 to version 3.0.0, using simplified selection for compression/decompression:
User can select between F32 or F64, for 1D with "fixed" encoding.
Futurely a new selection can be implemented for dimensions and encoding options.