Add Helm subchart for cert-manager to manage TLS certificates#325
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements TLS support for Silver services via cert-manager and Let's Encrypt, adding a bootstrap script for Cloudflare DNS-01 challenges and updating Helm templates to manage Certificate resources. Review feedback suggests removing restrictive domain selectors in the ClusterIssuers to support multiple domains, utilizing the provided Helm helper for issuer references, and replacing a hardcoded sleep with a kubectl wait command for better reliability.
There was a problem hiding this comment.
Code Review
This pull request introduces TLS support for the Silver services using cert-manager and Let's Encrypt. Key additions include a bootstrap script for cluster infrastructure setup, comprehensive documentation in the README, and Helm templates for automated certificate generation. The review feedback suggests enhancing the bootstrap script's idempotency for namespace creation and improving the sanitization logic for Kubernetes resource names to handle a wider range of domain characters.
📌 Description
Implemented automated TLS certificate management with cert-manager and Let’s Encrypt in the existing Silver Helm deployment flow. Certificates are generated per configured domain, renewed automatically, and stored as Kubernetes Secrets for downstream services.
🔍 Changes Made
1. Certificate templating in Helm
2. Issuer integration
3. ACME + DNS challenge bootstrap
4. Operational documentation
Design Decisions
✅ Checklist (Email System)
🧪 Testing Instructions